From 4904a0ea202d4c476f11e165450dbac40e740482 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Sat, 24 Mar 2018 17:58:08 -0700 Subject: [PATCH] Sort existing_rulesets by _ordering desc, so default is removed first --- octodns/provider/dyn.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/octodns/provider/dyn.py b/octodns/provider/dyn.py index ef989bd..cb0dabf 100644 --- a/octodns/provider/dyn.py +++ b/octodns/provider/dyn.py @@ -535,6 +535,12 @@ class DynProvider(BaseProvider): for ruleset in existing_rulesets: for pool in ruleset.response_pools: pools[pool.response_pool_id] = pool + # Reverse sort the existing_rulesets by _ordering so that we'll remove + # them in that order later, this will ensure that we remove the old + # default before any of the old geo rules preventing it from catching + # everything. + existing_rulesets.sort(key=lambda r: r._ordering, reverse=True) + # Now we need to find any pools that aren't referenced by rules for pool in td.all_response_pools: rpid = pool.response_pool_id