From 988e8d27fb61ab86a7e8f565c53cf3ff9fae3de7 Mon Sep 17 00:00:00 2001
From: "Yaroshevich, Denis" <d.yaroshevich@itransition.com>
Date: Fri, 9 Apr 2021 11:45:40 +0300
Subject: [PATCH] fix populate for multiple resource records in single rrset

---
 octodns/provider/gcore.py            | 20 +++++++++++++++++---
 tests/fixtures/gcore-no-changes.json |  5 ++++-
 2 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/octodns/provider/gcore.py b/octodns/provider/gcore.py
index 60e8bad..5582dd8 100644
--- a/octodns/provider/gcore.py
+++ b/octodns/provider/gcore.py
@@ -36,9 +36,10 @@ class GCoreClient(object):
 
     ROOT_ZONES = "/zones"
 
-    def __init__(self, base_url, token):
+    def __init__(self, log, base_url, token):
         session = Session()
         session.headers.update({"Authorization": "Bearer {}".format(token)})
+        self.log = log
         self._session = session
         self._base_url = base_url
 
@@ -48,10 +49,19 @@ class GCoreClient(object):
             method, url, params=params, json=data, timeout=30.0
         )
         if r.status_code == 400:
+            self.log.error(
+                "bad request %r has been sent to %r: %s", data, url, r.text
+            )
             raise GCoreClientBadRequest(r)
         elif r.status_code == 404:
+            self.log.error(
+                "resource %r not found: %s", url, r.text
+            )
             raise GCoreClientNotFound(r)
         elif r.status_code == 500:
+            self.log.error(
+                "server error no %r to %r: %s", data, url, r.text
+            )
             raise GCoreClientException(r)
         r.raise_for_status()
         return r
@@ -112,13 +122,17 @@ class GCoreProvider(BaseProvider):
         self.log = logging.getLogger("GCoreProvider[{}]".format(id))
         self.log.debug("__init__: id=%s, token=***", id)
         super(GCoreProvider, self).__init__(id, *args, **kwargs)
-        self._client = GCoreClient(base_url, token)
+        self._client = GCoreClient(self.log, base_url, token)
 
     def _data_for_single(self, _type, record):
         return {
             "ttl": record["ttl"],
             "type": _type,
-            "values": record["resource_records"][0]["content"],
+            "values": [
+                rr_value
+                for resource_record in record["resource_records"]
+                for rr_value in resource_record["content"]
+            ],
         }
 
     _data_for_A = _data_for_single
diff --git a/tests/fixtures/gcore-no-changes.json b/tests/fixtures/gcore-no-changes.json
index ad62c94..a70fb82 100644
--- a/tests/fixtures/gcore-no-changes.json
+++ b/tests/fixtures/gcore-no-changes.json
@@ -5,7 +5,10 @@
         "ttl": 300,
         "resource_records": [{
             "content": [
-                "1.2.3.4",
+                "1.2.3.4"
+            ]
+        }, {
+            "content": [
                 "1.2.3.5"
             ]
         }]