From a2891ea8f20008bb0f1a4cead49fd447353bfe9d Mon Sep 17 00:00:00 2001 From: Adam Amstrong Date: Wed, 4 May 2011 11:04:19 +0000 Subject: [PATCH] fix sensors (maybe) git-svn-id: http://www.observium.org/svn/observer/trunk@2236 61d68cd4-352d-0410-923a-c4978735b2b8 --- includes/discovery/cisco-entity-sensor.inc.php | 6 +++--- includes/discovery/current.inc.php | 6 +++--- includes/discovery/current/apc.inc.php | 8 ++++---- includes/discovery/current/gamatronicups.inc.php | 6 +++--- includes/discovery/current/ipoman.inc.php | 6 +++--- includes/discovery/current/mgeups.inc.php | 6 +++--- includes/discovery/current/netvision.inc.php | 6 +++--- includes/discovery/current/rfc1628.inc.php | 10 +++++----- includes/discovery/current/sentry3.inc.php | 6 +++--- includes/discovery/current/xups.inc.php | 8 ++++---- includes/discovery/entity-sensor.inc.php | 4 ++-- includes/discovery/fanspeeds.inc.php | 6 +++--- includes/discovery/fanspeeds/areca.inc.php | 4 ++-- includes/discovery/fanspeeds/lmsensors.inc.php | 4 ++-- includes/discovery/fanspeeds/supermicro.inc.php | 4 ++-- includes/discovery/frequencies.inc.php | 4 ++-- includes/discovery/frequencies/apc.inc.php | 10 +++++----- includes/discovery/frequencies/ipoman.inc.php | 4 ++-- includes/discovery/frequencies/mgeups.inc.php | 6 +++--- includes/discovery/frequencies/netvision.inc.php | 6 +++--- includes/discovery/frequencies/rfc1628.inc.php | 8 ++++---- includes/discovery/frequencies/xups.inc.php | 8 ++++---- includes/discovery/humidity.inc.php | 11 +++-------- includes/discovery/humidity/akcp.inc.php | 4 ++-- includes/discovery/humidity/ipoman.inc.php | 4 ++-- includes/discovery/humidity/sentry3.inc.php | 4 ++-- includes/discovery/ipmi.inc.php | 4 ++-- includes/discovery/power.inc.php | 4 ++-- includes/discovery/sensors.inc.php | 6 +----- includes/discovery/temperatures.inc.php | 6 +++--- includes/discovery/temperatures/akcp.inc.php | 4 ++-- includes/discovery/temperatures/aos-device.inc.php | 4 ++-- includes/discovery/temperatures/apc.inc.php | 6 +++--- includes/discovery/temperatures/areca.inc.php | 6 +++--- includes/discovery/temperatures/cisco-envmon.inc.php | 4 ++-- .../discovery/temperatures/cometsystem-p85xx.inc.php | 4 ++-- includes/discovery/temperatures/dell.inc.php | 4 ++-- .../discovery/temperatures/ftos-c-series.inc.php | 4 ++-- .../discovery/temperatures/ftos-e-series.inc.php | 4 ++-- .../discovery/temperatures/ftos-s-series.inc.php | 4 ++-- includes/discovery/temperatures/ipoman.inc.php | 4 ++-- includes/discovery/temperatures/ironware.inc.php | 4 ++-- includes/discovery/temperatures/junos.inc.php | 4 ++-- includes/discovery/temperatures/junose.inc.php | 4 ++-- includes/discovery/temperatures/lm-sensors.inc.php | 4 ++-- .../temperatures/observernms-custom.inc.php | 4 ++-- includes/discovery/temperatures/papouch-tme.inc.php | 4 ++-- includes/discovery/temperatures/powerconnect.inc.php | 4 ++-- includes/discovery/temperatures/rfc1628.inc.php | 4 ++-- includes/discovery/temperatures/sentry3.inc.php | 4 ++-- includes/discovery/temperatures/supermicro.inc.php | 4 ++-- includes/discovery/temperatures/xups.inc.php | 4 ++-- includes/discovery/temperatures/zyxel-ies.inc.php | 4 ++-- includes/discovery/voltages.inc.php | 6 +++--- includes/discovery/voltages/apc.inc.php | 12 ++++++------ includes/discovery/voltages/areca.inc.php | 4 ++-- includes/discovery/voltages/gamatronicups.inc.php | 6 +++--- includes/discovery/voltages/ipoman.inc.php | 4 ++-- includes/discovery/voltages/linux.inc.php | 6 ++---- includes/discovery/voltages/mgeups.inc.php | 6 +++--- includes/discovery/voltages/netvision.inc.php | 8 ++++---- includes/discovery/voltages/rfc1628.inc.php | 10 +++++----- includes/discovery/voltages/sentry3.inc.php | 4 ++-- includes/discovery/voltages/supermicro.inc.php | 4 ++-- includes/discovery/voltages/xups.inc.php | 10 +++++----- 65 files changed, 172 insertions(+), 183 deletions(-) diff --git a/includes/discovery/cisco-entity-sensor.inc.php b/includes/discovery/cisco-entity-sensor.inc.php index a686c28ab3..05329c3807 100644 --- a/includes/discovery/cisco-entity-sensor.inc.php +++ b/includes/discovery/cisco-entity-sensor.inc.php @@ -1,6 +1,6 @@ \ No newline at end of file +?> diff --git a/includes/discovery/current/apc.inc.php b/includes/discovery/current/apc.inc.php index f8526e3680..ed2e37a4f5 100644 --- a/includes/discovery/current/apc.inc.php +++ b/includes/discovery/current/apc.inc.php @@ -1,6 +1,6 @@ = 0) { - discover_sensor($valid_sensor, 'current', $device, $infeed_oid, $towers, 'sentry3', $descr, $divisor, $multiplier, $low_limit, $low_warn_limit, $high_warn_limit, $high_limit, $current); + discover_sensor($valid['sensor'], 'current', $device, $infeed_oid, $towers, 'sentry3', $descr, $divisor, $multiplier, $low_limit, $low_warn_limit, $high_warn_limit, $high_limit, $current); } ################################# @@ -75,7 +75,7 @@ if ($device['os'] == 'sentry3') $outlet_current = snmp_get($device,"$outlet_oid", "-Ovq", "Sentry3-MIB") / $outlet_divisor; if ($outlet_current >= 0) { - discover_sensor($valid_sensor, 'current', $device, $outlet_oid, $outlet_insert_index, 'sentry3', $outlet_descr, $outlet_divisor, $multiplier, $outlet_low_limit, $outlet_low_warn_limit, $outlet_high_warn_limit, $outlet_high_limit, $outlet_current); + discover_sensor($valid['sensor'], 'current', $device, $outlet_oid, $outlet_insert_index, 'sentry3', $outlet_descr, $outlet_divisor, $multiplier, $outlet_low_limit, $outlet_low_warn_limit, $outlet_high_warn_limit, $outlet_high_limit, $outlet_current); } } // if ($outlet_data) diff --git a/includes/discovery/current/xups.inc.php b/includes/discovery/current/xups.inc.php index 1d8dfa7275..bee5cfcc37 100644 --- a/includes/discovery/current/xups.inc.php +++ b/includes/discovery/current/xups.inc.php @@ -1,6 +1,6 @@ \ No newline at end of file +?> diff --git a/includes/discovery/fanspeeds/areca.inc.php b/includes/discovery/fanspeeds/areca.inc.php index f29f3f83ca..98864ae387 100644 --- a/includes/discovery/fanspeeds/areca.inc.php +++ b/includes/discovery/fanspeeds/areca.inc.php @@ -1,6 +1,6 @@ '0') { - discover_sensor($valid_sensor, 'fanspeed', $device, $oid, $index, 'lmsensors', $descr, '1', '1', NULL, NULL, NULL, NULL, $current); + discover_sensor($valid['sensor'], 'fanspeed', $device, $oid, $index, 'lmsensors', $descr, '1', '1', NULL, NULL, NULL, NULL, $current); } } } diff --git a/includes/discovery/fanspeeds/supermicro.inc.php b/includes/discovery/fanspeeds/supermicro.inc.php index cf5e800da9..382b052e61 100644 --- a/includes/discovery/fanspeeds/supermicro.inc.php +++ b/includes/discovery/fanspeeds/supermicro.inc.php @@ -1,6 +1,6 @@ 1) { $descr .= " $index"; } - discover_sensor($valid_sensor, 'frequency', $device, $oid, "4.2.1.4.$index", $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); + discover_sensor($valid['sensor'], 'frequency', $device, $oid, "4.2.1.4.$index", $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); } } @@ -53,7 +53,7 @@ if ($device['os'] == "apc") $type = "apc"; $index = "3.2.4.0"; $descr = "Input"; - discover_sensor($valid_sensor, 'frequency', $device, $oid, $index, $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); + discover_sensor($valid['sensor'], 'frequency', $device, $oid, $index, $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); } $oids = snmp_get($device, "1.3.6.1.4.1.318.1.1.1.4.2.2.0", "-OsqnU", ""); @@ -66,7 +66,7 @@ if ($device['os'] == "apc") $type = "apc"; $index = "4.2.2.0"; $descr = "Output"; - discover_sensor($valid_sensor, 'frequency', $device, $oid, $index, $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); + discover_sensor($valid['sensor'], 'frequency', $device, $oid, $index, $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); } } diff --git a/includes/discovery/frequencies/ipoman.inc.php b/includes/discovery/frequencies/ipoman.inc.php index 479699deca..abfadee184 100644 --- a/includes/discovery/frequencies/ipoman.inc.php +++ b/includes/discovery/frequencies/ipoman.inc.php @@ -1,6 +1,6 @@ \ No newline at end of file diff --git a/includes/discovery/frequencies/rfc1628.inc.php b/includes/discovery/frequencies/rfc1628.inc.php index d5c3df3dd4..c04574eb2c 100644 --- a/includes/discovery/frequencies/rfc1628.inc.php +++ b/includes/discovery/frequencies/rfc1628.inc.php @@ -1,6 +1,6 @@ diff --git a/includes/discovery/frequencies/xups.inc.php b/includes/discovery/frequencies/xups.inc.php index d14c31cfa6..d5f97ea7b5 100644 --- a/includes/discovery/frequencies/xups.inc.php +++ b/includes/discovery/frequencies/xups.inc.php @@ -1,6 +1,6 @@ \ No newline at end of file +?> diff --git a/includes/discovery/humidity/akcp.inc.php b/includes/discovery/humidity/akcp.inc.php index 3a33ce0297..32973d1b31 100644 --- a/includes/discovery/humidity/akcp.inc.php +++ b/includes/discovery/humidity/akcp.inc.php @@ -1,6 +1,6 @@ = 0) { - discover_sensor($valid_sensor, 'humidity', $device, $humidity_oid, $index, 'sentry3', $descr, $divisor, $multiplier, $low_limit, $low_warn_limit, $high_warn_limit, $high_limit, $current); + discover_sensor($valid['sensor'], 'humidity', $device, $humidity_oid, $index, 'sentry3', $descr, $divisor, $multiplier, $low_limit, $low_warn_limit, $high_warn_limit, $high_limit, $current); } } unset($data); diff --git a/includes/discovery/ipmi.inc.php b/includes/discovery/ipmi.inc.php index df42b316b9..238128e182 100644 --- a/includes/discovery/ipmi.inc.php +++ b/includes/discovery/ipmi.inc.php @@ -1,6 +1,6 @@ diff --git a/includes/discovery/temperatures.inc.php b/includes/discovery/temperatures.inc.php index 1ff4e80207..183f5b7d15 100755 --- a/includes/discovery/temperatures.inc.php +++ b/includes/discovery/temperatures.inc.php @@ -4,10 +4,10 @@ echo("Temperatures: "); include_dir("includes/discovery/temperatures"); -if ($debug) { print_r($valid_sensor['temperature']); } +if ($debug) { print_r($valid['sensor']['temperature']); } -check_valid_sensors($device, 'temperature', $valid_sensor); +check_valid_sensors($device, 'temperature', $valid['sensor']); echo("\n"); -?> \ No newline at end of file +?> diff --git a/includes/discovery/temperatures/akcp.inc.php b/includes/discovery/temperatures/akcp.inc.php index 69284e6f91..860bf13968 100644 --- a/includes/discovery/temperatures/akcp.inc.php +++ b/includes/discovery/temperatures/akcp.inc.php @@ -1,6 +1,6 @@ "0") { $temperature_oid = ".1.3.6.1.4.1.18248.1.1.1.0"; - discover_sensor($valid_sensor, 'temperature', $device, ".1.3.6.1.4.1.6486.800.1.2.1.16.1.1.1.17.0", "1", 'alcatel-device', $descr, '1', '1', NULL, NULL, NULL, NULL, $temperature); + discover_sensor($valid['sensor'], 'temperature', $device, ".1.3.6.1.4.1.6486.800.1.2.1.16.1.1.1.17.0", "1", 'alcatel-device', $descr, '1', '1', NULL, NULL, NULL, NULL, $temperature); } } diff --git a/includes/discovery/temperatures/apc.inc.php b/includes/discovery/temperatures/apc.inc.php index 5a32ac5b57..96b06cf511 100644 --- a/includes/discovery/temperatures/apc.inc.php +++ b/includes/discovery/temperatures/apc.inc.php @@ -1,6 +1,6 @@ = 0) { - discover_sensor($valid_sensor, 'temperature', $device, $temperature_oid, $index, 'sentry3', $descr, $divisor, $multiplier, $low_limit, $low_warn_limit, $high_warn_limit, $high_limit, $current); + discover_sensor($valid['sensor'], 'temperature', $device, $temperature_oid, $index, 'sentry3', $descr, $divisor, $multiplier, $low_limit, $low_warn_limit, $high_warn_limit, $high_limit, $current); } } unset($data); diff --git a/includes/discovery/temperatures/supermicro.inc.php b/includes/discovery/temperatures/supermicro.inc.php index 96481d2d85..e37803557c 100644 --- a/includes/discovery/temperatures/supermicro.inc.php +++ b/includes/discovery/temperatures/supermicro.inc.php @@ -1,6 +1,6 @@ \ No newline at end of file +?> diff --git a/includes/discovery/voltages/apc.inc.php b/includes/discovery/voltages/apc.inc.php index 635748a237..63ee632674 100644 --- a/includes/discovery/voltages/apc.inc.php +++ b/includes/discovery/voltages/apc.inc.php @@ -1,6 +1,6 @@ 1) { $descr .= " $index"; } - discover_sensor($valid_sensor, 'voltage', $device, $oid, "4.3.1.3.$index", $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); + discover_sensor($valid['sensor'], 'voltage', $device, $oid, "4.3.1.3.$index", $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); } } @@ -56,7 +56,7 @@ if ($device['os'] == "apc") $index = "3.2.1.0"; $descr = "Input"; - discover_sensor($valid_sensor, 'voltage', $device, $oid, $index, $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); + discover_sensor($valid['sensor'], 'voltage', $device, $oid, $index, $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); } $oids = snmp_get($device, "1.3.6.1.4.1.318.1.1.1.4.2.1.0", "-OsqnU", ""); @@ -70,7 +70,7 @@ if ($device['os'] == "apc") $index = "4.2.1.0"; $descr = "Output"; - discover_sensor($valid_sensor, 'voltage', $device, $oid, $index, $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); + discover_sensor($valid['sensor'], 'voltage', $device, $oid, $index, $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); } #PDU @@ -86,7 +86,7 @@ if ($device['os'] == "apc") $index = "1"; $descr = "Input"; - discover_sensor($valid_sensor, 'voltage', $device, $oid, $index, $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); + discover_sensor($valid['sensor'], 'voltage', $device, $oid, $index, $type, $descr, $divisor, '1', NULL, NULL, NULL, NULL, $current); } } diff --git a/includes/discovery/voltages/areca.inc.php b/includes/discovery/voltages/areca.inc.php index e111496530..df86c7b20c 100644 --- a/includes/discovery/voltages/areca.inc.php +++ b/includes/discovery/voltages/areca.inc.php @@ -1,6 +1,6 @@ \ No newline at end of file +?> diff --git a/includes/discovery/voltages/mgeups.inc.php b/includes/discovery/voltages/mgeups.inc.php index bd7aa6f5ef..2888a140dd 100644 --- a/includes/discovery/voltages/mgeups.inc.php +++ b/includes/discovery/voltages/mgeups.inc.php @@ -1,6 +1,6 @@