Commit Graph
836 Commits
Author SHA1 Message Date
071ca9bc2a Apply fixes from StyleCI (#15698)
Co-authored-by: StyleCI Bot <[email protected]>
2024-01-04 22:39:12 -06:00
Ville HukkamäkiandGitHub 2ed5afc826 Fix Rancid error messages (#15683)
* Fix Rancid error messages

* Fix code style issues.
2023-12-31 13:19:32 +01:00
Justin LentzandGitHub 8e62ad53b4 Clarify In/Out (#15680) 2023-12-30 18:48:22 +01:00
Garcia MICHELandGitHub d8eec57690 Fix pagination in alert rules page (#15659) 2023-12-19 10:37:10 -06:00
759390ba4b WebUI - Filter FDB and ARP tabs in port page if empty (#15653)
Tested OK

---------

* filter FDB and ARP tabs in port page
* style
* Use relationships

---------

Co-authored-by: Tony Murray <[email protected]>
2023-12-18 08:08:56 +01:00
Tony MurrayandGitHub e7114e33f9 API add_device: Add ping_ping fallback option (#15637)
* API add_device: Add ping_ping fallback option
improve docs a little

* More docs refinement
2023-12-17 18:08:37 +01:00
Neil LathwoodandGitHub 3951bbb248 Update query to be more efficient (#15622) 2023-12-14 10:33:01 +01:00
StefandGitHub ad805f4504 more filter options for the BGP peer API endpoint (#15599)
* Add more filter options for the BGP API endpoint. bgp_descr, bgp_state and bgp_adminstate

* typo and lint

* Adress family filter would also be helpful. casting AS1234 Like inputs to plain numbers

* linting again...
2023-11-29 21:58:30 +01:00
Justin LentzandGitHub de793099e4 Add space to Oxidized error msg (#15603) 2023-11-29 21:53:39 +01:00
not-knownandGitHub cf69a00cd0 Add option to disable the send of acknowledgement alerts. (#15208) 2023-11-13 21:56:06 -06:00
Arjen ZonneveldandGitHub 937d37dc18 Change spelling disc -> disk (#15569)
Disc is typically used for optical media, not hard disks (so unlikely
to encounter discs in mdraid related circumstances).
mdadm and friends use the disk spelling, the host script also shows
shows this `"disc_count": $(maybe_get "${mdadmSysDev}/md/raid_disks"),`

Fixing the variable names as well would be nice, but that change would
be a lot bigger and probably break things as it would need host script
adjustment synchronising and all that, but I think we can at least
change the cosmetic spelling.

https://en.wikipedia.org/wiki/Spelling_of_disc
2023-11-11 00:15:46 -06:00
Tony MurrayandGitHub 3a98aa2ec6 API Oxidized source optimization (#15560)
* API Oxidized source optimization
Don't fetch the device twice from the database.

* qualify device_id
2023-11-07 15:44:47 -06:00
Tony MurrayandGitHub 489978a923 Fix graphs device check before auth (#15551)
It should be after the auth check.
2023-11-06 09:09:25 -06:00
d5c6d0aaf4 Fixed BGP Remote peer link and graph in Routing Overview, or just static text when not a device in LibreNMS (#15535)
* Fixed BGP Remote peer link and graph in Routing Overview, or just static text when not a device in LibreNMS

* Added extra space

* Reverted back to overlibLink (due to BGP update graphs on hover)

* Added extra space

* Remove graph for remote peer, as it is falsely (showed earlier the Updates Graph for local peer)

* Removed unnecessary/unused code

* Remove graph for remote peer, as it is falsely (showed earlier the Updates Graph for local peer), replaced with just a DeviceLinks

* Change Url::deviceLink to return $text if the device doesn't exist.  Default to ''
Import some of the things to improve readability.

* update phpdoc

---------

Co-authored-by: Tony Murray <[email protected]>
2023-11-02 00:41:19 -05:00
WheelandGitHub f0bbab2419 Minor fix and tweak for graylog integration (#15455)
* Minor fix and tweak for graylog integration

* More flexible in other use cases

* fix again?
2023-11-01 22:35:44 -05:00
9ca95a9ba5 Dark mode fix routing tabs & pages (#15485)
* Dark mode fix routing tabs

* Fix styling

* Fix styling

* move tbody

---------

Co-authored-by: Tony Murray <[email protected]>
2023-11-01 22:34:09 -05:00
47c6842b01 API: get poller group (#15493)
* API: get poller group

* missed string in doc

* return all poller groups if name/id aren't specified

* add missing doc link

* style fixes

* more style

---------

Co-authored-by: Tony Murray <[email protected]>
2023-11-01 22:33:35 -05:00
Tony MurrayandGitHub 95eab0d42e Fix health temperature degree display (#15541)
* Fix health temperature degree display
It will be converted to html later. (otherwise it was double converted)

* Remove all &deg; it will only cause troubles
2023-11-01 20:35:35 +01:00
Tim de BoerandGitHub bcf700c5fe Added BGP Remote peer link and graph in Routing Overview (#15532) 2023-10-31 13:27:21 -05:00
Tony MurrayandGitHub 91b829edd3 Fix API get_location by ID (#15506) 2023-10-25 13:05:04 -05:00
Tony MurrayandGitHub 0e453e5938 API: allow add device to set location (#15469) 2023-10-18 02:00:39 -05:00
Tony MurrayandGitHub a51e70d067 Graphing: error when device is not found (#15459) 2023-10-15 06:02:21 -05:00
bnericksonandGitHub 78a4bfb9d9 Adding Socket Statistic Application Support (#15307) 2023-10-13 22:45:03 -05:00
Tony MurrayandGitHub a5198d7d57 Remove some lightly used or unused dbFacile functions (#15418)
* Remove some lightly used or unused dbFacile functions
['NULL'] legacy behavior seems unsupported, replace with actual nulls

* Fix refactor mishap

* another

* update baseline

* these were very wrong... what happened?
2023-10-12 09:15:03 -05:00
Tony MurrayandGitHub 0540c56d0f Add application metrics model and relationships (#15417)
* Add application metrics model and relationships

* update schema check file

* Add missed index

* Update testing definition

* sqlite can't create the id later

* update schema dumps

* update testing_persistent schema

* update baseline
2023-10-12 02:24:27 -05:00
Tony MurrayandGitHub aa455862e9 Fix bug saving snmpv3 device changes (#15419) 2023-10-08 18:56:48 -05:00
c87c6e8b8e Remove legacy addhost code (#15376)
* Remove legacy addhost code
Update webui addhost
Update device snmp settings page
Update discovery protocols device discovery (no longer force full new device discovery in process)

* remove baseline exceptions

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <[email protected]>
2023-10-07 22:02:45 -05:00
Tony MurrayandGitHub ac23c133d9 Fix an agent bug if a process ran more than 999 days (#15411)
* Fix an agent bug if a process ran more than 999 days
Increase it to 274 years before that happens ;)
Fix a few other small bugs

* Update schema check file
2023-10-07 20:14:00 -05:00
Tony MurrayandGitHub e53436b6a3 Calculate downtime from device_outages table (#15397)
* Calculate downtime from device_outages table

* refactor
2023-10-06 20:37:23 -05:00
Tony MurrayandGitHub 6d9178cd42 Fix graph errors (#15407)
Some graphs were generating an error that wasn't being correctly output as an image
2023-10-06 08:22:22 -05:00
d8c372bbf4 Refactor MAC utilities into a single class (#15379)
* Refactor MAC utils to a new utility class

* Apply fixes from StyleCI

* Inline functions
Add tests
Handle bridgeid format

* Apply fixes from StyleCI

* Dedicated code path for stp bridge parsing, and improve STP output a bit

* Correctly parse dot1dBaseBridgeAddress and don't store int in bool field

* trim any unexpected character from bridge addresses, add extra test data.

* better comment

* barsBridge can handle dot1dBaseBridgeAddress correctly now

* parseBridge, check for properly formatted mac first.

* update test data, empty data = empty mac

* Fix new usage after rebase

* import

---------

Co-authored-by: StyleCI Bot <[email protected]>
2023-10-06 07:34:14 -05:00
Tony MurrayandGitHub 908aef6596 Fix MAC search sql injection (#15402)
unparameterized variable
2023-10-05 23:04:04 -05:00
Tony MurrayandGitHub 7fe2614114 Fix xss in device groups overview (#15399) 2023-10-05 23:03:26 -05:00
Tony MurrayandGitHub 37eb0f1fa6 Hide unchangeable core module (#15395)
Core is an internal module do not show a toggle for it as it cannot be disabled.
2023-10-05 21:00:14 -05:00
Tony MurrayandGitHub 9fca01830c Update Tnmsne table backend (#15384)
remove ridiculous sql injection vulnerability
2023-10-05 10:32:21 +02:00
e0444bffcf Deprecate poller.php (#15370)
* Deprecate poller.php

* Apply fixes from StyleCI

* Remove references to poller.php
Leave wrapper...

* fix python style

* update wraper to call lnms device:poll

* Quiet output too

* make pb happy

---------

Co-authored-by: StyleCI Bot <[email protected]>
2023-10-04 16:32:02 -05:00
c1258320f8 Availability module fixes (#15369)
* Refactor poller to allow modules to run even if the device is down
Include core in config (but not webui) to avoid silly shenanigans
Inject datastore into polling

* Needed to split datastore interface

* Cleanup some data_udpate() references

* Apply fixes from StyleCI

* Fix legacy poller :D

* Output to the correct stream

* Fix lint issues

* Apply fixes from StyleCI

* Fix discovery not including core and submodule handling

* Use whereRaw

---------

Co-authored-by: StyleCI Bot <[email protected]>
2023-10-04 10:32:59 -05:00
4211b1c46f Remove unused functions (#15371)
* Remove unused functions
inline other legacy functions

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <[email protected]>
2023-10-04 10:17:34 -05:00
Tim de BoerandGitHub 15fd452b8a Added extra ASN-range comments, added Priv eBGP on host details, changed color to light-blue instead of red (#15372) 2023-10-04 10:07:14 -05:00
SourceDoctorandGitHub 65daa10b1b sort services by type and name (#15367) 2023-10-04 01:40:53 -05:00
Tim de BoerandGitHub 36cc6c3237 Fixing Private eBGP visualization, corrected 16bit ASN private range, added 32bit ASN range (#15357)
* Updated Install-LibreNMS.md

Default PHP version of Debian 11 (following this documentation) is 8.2 currently, instead of 8.1

* Fixed Markdown/Parse mode for Telegram

* Fixing Private eBGP visualization, corrected 16bit ASN private range, added 32bit ASN range

* Removed quotes
2023-09-27 13:48:27 -05:00
Tim de BoerandGitHub c1008c44b8 Fix BGP peer IP missing in Routing page (#15352)
* Updated Install-LibreNMS.md

Default PHP version of Debian 11 (following this documentation) is 8.2 currently, instead of 8.1

* Fixed Markdown/Parse mode for Telegram

* Changed peer_iden to peer_addr in routing/bgp.inc.php
2023-09-27 07:14:13 -05:00
TimandGitHub 2ee837eb90 Fix incorrect pages offset on app ntp page (#15349)
* Update app_ntp.inc.php

Fixes ISSUE 15344
- Corrects start point in table when showing NTP APP
- Corrects blank page when showing ALL NTP entries

* Update app_ntp.inc.php

Use row count for page start not a hard coded 10
2023-09-26 20:47:45 -05:00
PipoCanajaandGitHub 6ba103db68 Device NAC page to Laravel Blade (#15329) 2023-09-24 15:19:25 -05:00
SourceDoctorandGitHub 5c9f3c80e5 show device group on device overview (#15338)
* show device group on device overview

* .

* better styling on device group display
2023-09-24 11:32:01 -05:00
SourceDoctorandGitHub 6e592f99c1 Scale disk spezific SMART Graph from 0 (#15339) 2023-09-24 18:12:11 +02:00
SourceDoctorandGitHub c0a233700c show never polled information (#15341) 2023-09-24 18:10:11 +02:00
SourceDoctorandGitHub 88eee297c4 show Temperature Graphs on Smart App Overview (#15342) 2023-09-24 18:09:25 +02:00
Tony MurrayandGitHub 274a89bcb4 Fix eventlog debug code left in (#15331) 2023-09-18 09:14:52 -05:00
Tony MurrayandGitHub 8fd8d9b06a Fix unescaped output in ipv6 search page (#15327) 2023-09-15 16:05:08 -05:00